Messages in this thread |  | | | Date | Tue, 25 Mar 2003 14:38:53 -0800 | | From | William Lee Irwin III <> | | Subject | Re: [PATCH] swap 11/13 fix unuse_pmd fixme |
| |
On Tue, Mar 25, 2003 at 10:21:51PM +0000, Hugh Dickins wrote: > try_to_unuse drop mmlist_lock across unuse_process (with pretty dance > of atomic_incs and mmputs of various mmlist markers, and a polite new > cond_resched there), so unuse_process can pte_chain_alloc(GFP_KERNEL) > and pass that down and down and down and down to unuse_pte: which > cannot succeed more than once on a given mm (make that explicit by > returning back up once succeeded). Preliminary checks moved up from > unuse_pte to unuse_pmd, and done more efficiently (avoid that extra > pte_file test added recently), swapoff spends far too long in here. > Updated locking comments and references to try_to_swap_out. Aha, the unlock_page() and the contorted loop breakout were wrong in my patch. Well, that and the cleanup of fossilized comments dating back to the Silurian is nice.
-- wli - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |