lkml.org 
[lkml]   [2003]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] reduce stack in cdrom/optcd.c
    On Tue, 25 Mar 2003 19:29:16 +0100 Jens Axboe <axboe@suse.de> wrote:

    | On Sat, Mar 22 2003, Arjan van de Ven wrote:
    | > On Sat, 2003-03-22 at 21:43, Alan Cox wrote:
    | > > On Sat, 2003-03-22 at 06:51, Randy.Dunlap wrote:
    | > > > Hi,
    | > > >
    | > > > This reduces stack usage in drivers/cdrom/optcd.c by
    | > > > dynamically allocating a large (> 2 KB) buffer.
    | > > >
    | > > > Patch is to 2.5.65. Please apply.
    | > >
    | > > This loosk broken. You are using GFP_KERNEL memory allocations on the
    | > > read path of a block device. What happens if the allocation fails
    | > > because we need memory
    | >
    | > it's unlikely that you have your swap on the cdrom ;)
    |
    | your swap device could still be plugged behind your cdrom.

    I plan to change it as Alan suggested. Will do.

    --
    ~Randy
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:34    [W:0.020 / U:65.300 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site