lkml.org 
[lkml]   [2003]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: i2c-via686a driver
    On Tue, Mar 25, 2003 at 10:12:43AM +0100, Jan Dittmer wrote:
    > Greg KH wrote:
    > >On Sun, Mar 23, 2003 at 10:38:43PM +0100, Jan Dittmer wrote:
    > >
    > >>Anyway, here is a corrected version.
    > >
    > >
    > >Oops, one other thing. The pci_device_id structure should be
    > >initialized by using the .field = method, not the way the driver is
    > >currently.
    > >
    > >Oh, and one patch that adds the Kconfig, Makefile, and driver to the
    > >tree would be great.
    > >
    > I included that one with the first mail, but here it is again together
    > with the hopefully correctly fixed driver.

    Yes, but you didn't include it all in one patch. It's tough to apply a
    .c file with 'patch' :)

    Also, you need to set up the adapter.dev.parent pointer before calling
    i2c_add_adapter().

    Can you make that one change, and send a single patch?

    thanks,

    greg k-h
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:34    [W:0.019 / U:30.040 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site