lkml.org 
[lkml]   [2003]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: i2c-via686a driver
    On Sun, Mar 23, 2003 at 10:38:43PM +0100, Jan Dittmer wrote:
    > Christoph Hellwig wrote:
    > >On Sun, Mar 23, 2003 at 09:36:10PM +0100, Dominik Kubla wrote:
    > >
    > >>Why? It's a valid C99 feature and since the kernel already uses C99
    > >>initializers it won't compile with compilers that choke on C99 comments
    > >>anyway.
    > >
    > >
    > >Because there's a strong preference for traditional C style in the kernel.
    > >typedefs are also a valid C feature and we try to avoid them.
    > >
    > Anyway, here is a corrected version.

    Oops, one other thing. The pci_device_id structure should be
    initialized by using the .field = method, not the way the driver is
    currently.

    Oh, and one patch that adds the Kconfig, Makefile, and driver to the
    tree would be great.

    thanks again,

    greg k-h
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:34    [W:0.023 / U:63.468 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site