lkml.org 
[lkml]   [2003]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Multiple & vs. && and | vs. || bugs in 2.4.20
Hi,

On Sun, 2 Mar 2003, Ulrich Drepper wrote:

> > - if (!urb->status & !acm->throttle) {
> > + if (!urb->status && !acm->throttle) {
>
> [...]
>
> Observe the extra 'jne' and the fact that the value of 'throttle'
> element cannot be loaded until after the conditional jump. Not even
> out of order execution can arrange that.

But speculative execution can arrange that (providing the cpu predicted
the jump target correctly).

> To summarize, I'd probably not be amused if you would change any of my
> code which takes advantage of such programming finess.

If that was really intentional, I would assume to see something like this:

if (!(urb->status | acm->throttle)) {
bye, Roman

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:33    [W:0.095 / U:0.256 seconds]
©2003-2014 Jasper Spaans. Advertise on this site