lkml.org 
[lkml]   [2003]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2.5.65] pnp api changes to sound/isa/sb/es968.c


On Wed, 19 Mar 2003, Christoph Hellwig wrote:

> On Wed, Mar 19, 2003 at 07:03:57AM -0500, John Kim wrote:
> > struct snd_card_es968 {
> > -#ifdef __ISAPNP__
> > - struct isapnp_dev *dev;
> > -#endif /* __ISAPNP__ */
> > + struct pnp_dev *dev;
> > };
>
> What about completly removing struct snd_card_es968 and using pnp_dev
> directtly instead? sound/* is full of this overdesign and it's time
> to get it follow kernel style a bit more..

Perhaps the task of code clean up should be done in separate track than
pnp api conversion task?

> > static int __init alsa_card_es968_init(void)
> > {
> > int cards = 0;
> >
> > -#ifdef __ISAPNP__
> > - cards += isapnp_probe_cards(snd_es968_pnpids, snd_es968_isapnp_detect);
> > -#else
> > - snd_printk("you have to enable ISA PnP support.\n");
> > -#endif
> > + cards += pnp_register_card_driver(&es968_pnpc_driver);
> > #ifdef MODULE
> > if (!cards)
> > - snd_printk("no ES968 based soundcards found\n");
> > + printk(KERN_ERR "no ES968 based soundcards found\n");
> > #endif
> > return cards ? 0 : -ENODEV;
> > }
>
> That printk is useless, you get a useful message from modprobe on
> an ENODEV return anyway.

I'll make a new diff without useless printk line. Thank you.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:34    [W:0.072 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site