[lkml]   [2003]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] fix nanosleep() granularity bumps
    On Wed, 19 Mar 2003, george anzinger wrote:

    > In this case, the simple fix is to bump the
    > base->timer_jiffies at the beginning of the loop rather than the end.
    > This would cause the new timer to be put in the next jiffie instead
    > of the current one AND it is free!

    Yes, doing it this way looks correct to me.

    > > No, with the current implementation we need
    > > #define INDEX(N) (base->timer_jiffies >> (TVR_BITS + N * TVN_BITS) +1) &
    > > TVN_MASK
    > > although I'd like to see that cleaned up.
    > I tried with the +1 and boot hangs trying to set up networking. I
    > think the difference is that the init code is trying to set things up
    > the way they would look AFTER cascade executes and this is doing it
    > BEFORE the cascade call.

    With the above change, it should be correct without the +1

    > > Why 'jiffies -1'? This will just be made up for in the first
    > > timer interrupt, where timer_jiffies will get incremented twice.
    > Again, I removed the -1 in the attached.

    If you really want to be conservative, we'd better start with
    INITIAL_JIFFIES. Should be the same anyways. But if not, we might lose a
    timer scheduled for INITIAL_JIFFIES (not that I think it's possible to
    insert one before timer initialisation in the first place :-)
    or even a timer cascade.

    > > Did you bother to test the patch? It doesn't even boot for me, and I don't
    > > see how it is supposed to.
    > > I'll look into it more closely in the evening. Have to go to work now.
    > The old one ran on 2.5.64 but not 2.5.65 ??? I found and fixed a bug
    > (index needs to be caculated INSIDE the while loop) that seems to have
    > been the cause.

    Ok will test in the evening.


    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 13:34    [W:0.019 / U:7.276 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site