lkml.org 
[lkml]   [2003]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [2.4] init/do_mounts.c::rd_load_image() memleak
    Date
    From
    Oleg Drokin <green@namesys.com> said:
    > On Thu, Mar 13, 2003 at 10:03:08PM +0000, Russell King wrote:
    > > > + if (buf)
    > > > + kfree(buf);

    > > kfree(NULL); is valid - you don't need this check.

    > Almost every place I can think of does just this, so I do not see why this
    > particular piece of code should be different.

    Then the other code should be fixed. This is bloat.
    --
    Dr. Horst H. von Brand User #22616 counter.li.org
    Departamento de Informatica Fono: +56 32 654431
    Universidad Tecnica Federico Santa Maria +56 32 654239
    Casilla 110-V, Valparaiso, Chile Fax: +56 32 797513
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:33    [W:0.020 / U:60.068 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site