lkml.org 
[lkml]   [2003]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] i2c driver changes for 2.5.64
    On Fri, Mar 14, 2003 at 08:19:04AM +0000, Christoph Hellwig wrote:
    > > +/* Internally used pause function */
    > > +void ali15x3_do_pause(unsigned int amount)
    > > +{
    > > + current->state = TASK_INTERRUPTIBLE;
    > > + schedule_timeout(amount);
    > > +}
    >
    > I think this should be moved to linux/kernel.h as delay() - I've seen
    > it duplicated in so much code (including XFS)

    I'll move this. I think I have this in the usb.h header file too :)

    > > +#ifdef DEBUG
    > > + printk
    > > + ("i2c-ali15x3.o: Transaction (pre): STS=%02x, CNT=%02x, CMD=%02x, ADD=%02x, DAT0=%02x, "
    > > + "DAT1=%02x\n", inb_p(SMBHSTSTS), inb_p(SMBHSTCNT),
    > > + inb_p(SMBHSTCMD), inb_p(SMBHSTADD), inb_p(SMBHSTDAT0),
    > > + inb_p(SMBHSTDAT1));
    > > +#endif
    >
    > use pr_debug() here.

    In the next round of patches I'm using dev_dbg() and other dev_*
    functions for the printk calls, now that we have device support for the
    adapters.

    thanks,

    greg k-h
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:33    [W:0.019 / U:91.876 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site