[lkml]   [2003]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [2.4] init/do_mounts.c::rd_load_image() memleak

    On Fri, Mar 14, 2003 at 08:59:57AM +0100, Jens Axboe wrote:

    > > > > + if (buf)
    > > > > + kfree(buf);
    > > > kfree(NULL); is valid - you don't need this check.
    > > Almost every place I can think of does just this, so I do not see why this
    > > particular piece of code should be different.
    > Since when has that been a valid argument? :)

    Well, my argument is code uniformness which was always valid as long as it does not
    introduce any bugs, I think.
    Do you propose somebody should go and fix all
    if ( something )
    pieces of code to read just
    kfree(something); ?

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 13:33    [W:0.019 / U:10.428 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site