Messages in this thread | | | Date | Tue, 11 Mar 2003 21:19:07 -0800 | From | "H. Peter Anvin" <> | Subject | Re: [patch 3/3] add Via Nehemiah ("xstore") rng support |
| |
Jeff Garzik wrote: >> >> Note that your "=m" (*addr) is never actually used here -- it doesn't >> affect the instruction encoding, and it only shows up in a comment. >> Since gcc will generate an instruction mode here, it will be highly >> confused. >> >> I am assuming 0xC0 is a modr/m byte, in which case the most sane >> interpretation of this instruction would be "xstore %eax"; %edi is >> presumably implicit since you claim it can take a REP prefix... > > > and yet strangely the asm code seems to be correct :) >
Right... I got confused by the comment (the one inside the asm) and the fact that "addr" appeared twice. I think it's a bad comment; it draws attention to the wrong thing.
-hpa
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |