Messages in this thread | | | Date | Thu, 13 Mar 2003 00:46:03 +0300 (MSK) | From | "Ruslan U. Zakirov" <> | Subject | Comments on latest PNP changes. |
| |
Hello Adam and other. 2.5.64-bk6 1) Mem leak in your rewrite of als100 + err = pnp_activate_dev(pdev); + if (err < 0) { + printk(KERN_ERR PFX "AUDIO pnp configure failure\n"); + return err; + } Here you've forgot add "kfree(cfg);" 2) And here +MODULE_DEVICE_TABLE(pnp_card, snd_als100_pnpids); type must of entries must end with "device_id", but you've changed type from "pnp_card_device_id" to "pnp_card_id". This changes broke compilation. 3) When I need to activate(dev)? Thanks, Ruslan.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |