lkml.org 
[lkml]   [2003]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[2.4] Memleak in Essential RoadRunner HIPPI board driver
Hello!

There is memleak on error exit path. Seems there was some confusion
in the mind of whoever added that zeroing statement.
The patch is trivial, 2.5 is not affected.
Found with help of smatch + enhanced unfree script

Bye,
Oleg

===== drivers/net/rrunner.c 1.6 vs edited =====
--- 1.6/drivers/net/rrunner.c Thu Feb 28 16:57:24 2002
+++ edited/drivers/net/rrunner.c Wed Mar 12 22:05:15 2003
@@ -1216,7 +1216,6 @@

rrpriv->info = kmalloc(sizeof(struct rr_info), GFP_KERNEL);
if (!rrpriv->info){
- rrpriv->rx_ctrl = NULL;
ecode = -ENOMEM;
goto error;
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2005-03-22 13:33    [W:0.020 / U:0.496 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site