Messages in this thread | | | Date | Sat, 01 Mar 2003 12:23:09 -0500 | From | Jeff Garzik <> | Subject | Re: [PATCH] fix warning in drivers/net/sis900.c |
| |
Martin J. Bligh wrote: > drivers/net/sis900.c: In function `set_rx_mode': > drivers/net/sis900.c:2100: warning: passing arg 2 of `set_bit' from incompatible pointer type > > I just cast this. Seems to work fine at the moment, so presumably it's > correct.
Nope -- set_bit wants to work on a real unsigned long. While your patch will work, the proper fix is to not use set_bit :)
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |