Messages in this thread Patch in this message | | | Subject | Re: [PATCH 2.5] fix megaraid driver compile error | From | Steven Cole <> | Date | 06 Feb 2003 14:00:16 -0700 |
| |
On Thu, 2003-02-06 at 13:04, Linus Torvalds wrote: > > On 6 Feb 2003, Mark Haverkamp wrote: > > > > This moves access of the host element to device since host has been > > removed from struct scsi_cmnd. > > This is whitespace-damaged. > > Please fix broken mailers. I generally don't bother to fix up whitespace > damage from people who can't bother to have a good mailer. It's just not > worth it - if I try to fix it up (even if it is often trivial), it just > means that people will continue to send crap patches to me. > > Linus
In this case the issue is not a broken mailer, but rather the improper use of a good one. Mark is using Evolution and so am I. It appears that he did a cut and paste from an xterm (or something similar) which converted the tabs to spaces.
For other Evolution users out there, a better way to send patches with undamaged whitespace and not line-wrapped is to choose Insert and then Inline Text File. This will send a Linus-compatible inlined (not attached) patch.
Here is Mark's patch again, sent from Evolution, and not whitespace-damaged:
Steven
--- linux-2.5.59/drivers/scsi/megaraid.c.orig Thu Feb 6 13:31:24 2003 +++ linux-2.5.59/drivers/scsi/megaraid.c Thu Feb 6 13:33:06 2003 @@ -4515,7 +4515,7 @@ if(scsicmd == NULL) return -ENOMEM; memset(scsicmd, 0, sizeof(Scsi_Cmnd)); - scsicmd->host = shpnt; + scsicmd->device->host = shpnt; if( outlen || inlen ) { #if LINUX_VERSION_CODE >= KERNEL_VERSION(2,4,0) @@ -4652,7 +4652,7 @@ if(scsicmd == NULL) return -ENOMEM; memset(scsicmd, 0, sizeof(Scsi_Cmnd)); - scsicmd->host = shpnt; + scsicmd->device->host = shpnt; if (outlen || inlen) { #if LINUX_VERSION_CODE >= KERNEL_VERSION(2,4,0)
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |