Messages in this thread | | | Date | Tue, 4 Feb 2003 23:58:52 -0200 (BRST) | From | Rik van Riel <> | Subject | Re: [PATCH][RESEND 3] disassociate_ctty SMP fix |
| |
On Tue, 4 Feb 2003, Andrew Morton wrote: > Rik van Riel <riel@conectiva.com.br> wrote: > > > > ===== drivers/char/tty_io.c 1.55 vs edited ===== > > --- 1.55/drivers/char/tty_io.c Tue Jan 14 23:37:20 2003 > > +++ edited/drivers/char/tty_io.c Tue Feb 4 23:02:52 2003 > > @@ -425,19 +425,21 @@ > > */ > > void do_tty_hangup(void *data) > > { > > - struct tty_struct *tty = (struct tty_struct *) data;
> > - if (!tty) > > - return; > > - > > /* inuse_filps is protected by the single kernel lock */ > > lock_kernel();
[ move stuff to after the lock_kernel() ]
> This part is a no-op...
Mmmm Doh, local variable indeed ;/
I guess it's time to fix the caller of this function then, since something strange is going on here:
http://bugme.osdl.org/show_bug.cgi?id=54
Rik -- Bravely reimplemented by the knights who say "NIH". http://www.surriel.com/ http://guru.conectiva.com/ Current spamtrap: <a href=mailto:"october@surriel.com">october@surriel.com</a> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |