Messages in this thread | | | Date | Wed, 26 Feb 2003 10:19:05 -0100 | From | Dave Jones <> | Subject | Re: [PATCH][2.5] fix preempt-issues with smp_call_function() |
| |
On Wed, Feb 26, 2003 at 01:54:09AM -0800, Andrew Morton wrote:
> > Just one comment. You moved quite a few of the preempt_disable/enable > > pairs outside of the CONFIG_SMP checks. The issue we're working against > > here is to try and prevent preemption and ending up on a different CPU. > > As this cannot happen if CONFIG_SMP=n, I don't see why you've done this. > Just in two places.
Ok, slight exaggeration 8-) Looks good to me.
btw, (unrelated) shouldn't smp_call_function be doing magick checks with cpu_online() ?
Dave
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |