Messages in this thread | | | Date | Wed, 26 Feb 2003 09:37:42 -0100 | From | Dave Jones <> | Subject | Re: [PATCH][2.5] fix preempt-issues with smp_call_function() |
| |
On Tue, Feb 25, 2003 at 07:08:48PM +0100, Thomas Schlichter wrote:
> here is a patch to solve all (I hope I missed none) possible problems that > could occur on SMP machines running a preemptible kernel when > smp_call_function() calls a function which should be also executed on the > current processor. > > This patch is based on the one Dave Jones sent to the LKML last friday and > applies to the linux kernel version 2.5.63.
Just one comment. You moved quite a few of the preempt_disable/enable pairs outside of the CONFIG_SMP checks. The issue we're working against here is to try and prevent preemption and ending up on a different CPU. As this cannot happen if CONFIG_SMP=n, I don't see why you've done this.
Dave
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |