lkml.org 
[lkml]   [2003]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    Subject[PATCH 3/8] dm: prevent possible buffer overflow in ioctl interface
    From
    Use the correct size for "name" in register_with_devfs().

    During Al Viro's devfs cleanup a few versions ago, this function was
    rewritten, and the "name" string added. The 32-byte size is not large
    enough to prevent a possible buffer overflow in the sprintf() call,
    since the hash cell can have a name up to 128 characters.

    [Kevin Corry]

    --- diff/drivers/md/dm-ioctl.c 2003-02-26 16:09:42.000000000 +0000
    +++ source/drivers/md/dm-ioctl.c 2003-02-26 16:09:52.000000000 +0000
    @@ -173,7 +173,7 @@
    */
    static int register_with_devfs(struct hash_cell *hc)
    {
    - char name[32];
    + char name[DM_NAME_LEN + strlen(DM_DIR) + 1];
    struct gendisk *disk = dm_disk(hc->md);

    sprintf(name, DM_DIR "/%s", hc->name);
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2005-03-22 13:33    [W:4.095 / U:0.236 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site