Messages in this thread | | | From | Rolf Eike Beer <> | Subject | Re: [PATCH] Use hex numbers in fs/block_dev.c | Date | Wed, 26 Feb 2003 18:01:55 +0100 |
| |
Am Mittwoch, 26. Februar 2003 17:37 schrieb Jörn Engel: > On Wed, 26 February 2003 17:19:15 +0100, Rolf Eike Beer wrote: > > We're using hex numbers to identify devices in most places. We should use > > them in filesystem messages, errors etc. too, this would be much more > > consistent and avoids things like this where two different naming styles > > for the same error are used: > > > > end_request: [...] dev 16:45 (hdd), sector 9175248 > > EXT3-fs error (device ide1(22,69)): [...] inode=575269, > > block=1146906 > > > > With this patch the second message would look like this: > > > > EXT3-fs error (device ide1(16:45)): [...] inode=575269, > > block=1146906 > > Whis is _horrible_. Am I supposed to guess that ide does not use major > 16, so it will be 0x16 == 22 instead?
Of course, I know. But then we have to fix the end_request stuff also. And root=831 command line etc. This _is_ ugly. I just tried to make it one kind of ugly at all.
Eike - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |