lkml.org 
[lkml]   [2003]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [OOPS] 2.5.62, bootup, do_add_mount
    On Tue, Feb 25, 2003 at 12:04:48AM -0800, Andrew Morton wrote:
    > Maneesh Soni <maneesh@in.ibm.com> wrote:
    > >
    > >
    > > Hi Peter,
    > >
    > > presto_get_sb() is returning error resulting in the following NULL
    > > pointer reference in do_kern_mount(). The following patch corrects
    > > it.
    > >
    >
    > It should be returning some ERR_PTR value. Seems that presto_get_sb() isn't
    > very careful in tracking the reason for the failed mount, so
    >
    > return ERR_PTR(-EINVAL);
    >
    > should suffice.

    Actually previous fix I posted is not correct also. Returning -EINVAL seems
    logical.


    diff -urN linux-2.5.63-base/fs/intermezzo/super.c linux-2.5.63-presto_get_sb/fs/intermezzo/super.c
    --- linux-2.5.63-base/fs/intermezzo/super.c 2003-02-25 00:36:01.000000000 +0530
    +++ linux-2.5.63-presto_get_sb/fs/intermezzo/super.c 2003-02-25 15:14:09.000000000 +0530
    @@ -318,7 +318,7 @@

    CDEBUG(D_MALLOC, "mount error exit: kmem %ld, vmem %ld\n",
    presto_kmemory, presto_vmemory);
    - return NULL;
    + return ERR_PTR(-EINVAL);
    }


    Regards,
    Maneesh
    --
    Maneesh Soni
    IBM Linux Technology Center,
    IBM India Software Lab, Bangalore.
    Phone: +91-80-5044999 email: maneesh@in.ibm.com
    http://lse.sourceforge.net/
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:33    [W:0.022 / U:2.276 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site