Messages in this thread | | | Date | Tue, 25 Feb 2003 19:35:58 -0800 (PST) | Subject | Re: [PATCH] eliminate warnings in generated module files | From | "Randy.Dunlap" <> |
| |
> In message <Pine.LNX.4.44.0302251546590.2185-100000@home.transmeta.com> you > wri te: >> >> On Tue, 25 Feb 2003, Rusty Russell wrote: >> > >> > __optional should always be __attribute__((__unused__)), and >> > __required should be your __attribute_used__. >> >> But I think rth's point was that "__module_depends" should definitely >> _not_ be "optional", since that just means that the compiler can (and >> will) optimize away the whole thing. >> >> So marking it optional is definitely the wrong thing to do. > > This time for sure! > > Name: __optional attribute > Author: Rusty Russell > Status: Trivial
I have to agree with Kai and Milton Miller on this (bad) naming. __required and __optional don't generate the corrent connotations of what is being attempted here.
Milton suggesting spelling __attribute_used__ as __keep or __needed. I prefer __attribute_used__, but something like __mark_as_used__ would be OK too.
And what uses __optional, however it is spelled?
Thanks, ~Randy
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |