Messages in this thread | | | Date | Mon, 24 Feb 2003 21:48:35 +0100 (CET) | From | Folkert van Heusden <> | Subject | Re: [ACPI] [PATCH] 1/3 ACPI resource handling |
| |
> > 1) This seems like a good idea to simplify the parsing of the resource lists > > 2) I'm not convinced that this buys a whole lot -- it just hides the code > > behind a macro (something that's not generally liked in the Linux world.) > > Would this procedure be called from more than one place? > Well, reducing code duplication *is* liked in Linux world. Use inline > function instead of macro if possible, through.
Isn't it better to use functions instead of macro's? Reduces the code size--> less dirty cache-lines.
I saw, by the way, several functions duplicated in the networking-code. For example a lot of them have a net_random-alike function. Imho they should use the net_random in utils.c. Sadly my patches were ignored by the maintainers.
Folkert
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |