lkml.org 
[lkml]   [2003]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Linux 2.5.63
> <pam.delaney@lsil.com>:
> o Fusion Driver 2.05.00.03 against 2.5.62bk3

This update is broken and strange in many ways, it would have been
nice if you actually sent this to some list for review before submitting..

(1) there's stuff like:

#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,5,58)
#define mpt_inc_use_count()
#define mpt_dec_use_count()
#else
#define mpt_inc_use_count() MOD_INC_USE_COUNT
#define mpt_dec_use_count() MOD_DEC_USE_COUNT
#endif

but even if the old-style refcounting is deprecated now you can't
just simply remove it! you need to rearchitecture your code to
work with try_module_get/module_put

(2) and like this:

+#if LINUX_VERSION_CODE < KERNEL_VERSION(2,5,59)
MODULE_PARM(PortIo, "0-1i");
MODULE_PARM_DESC(PortIo, "[0]=Use mmap, 1=Use port io");
+#endif

Again. just because old-style module paramters are deprecated you can't
just remove them without replacement, use module_param() instead.

(3) you remove backward copatiblity code in one place but add lots more
in other places. this doesn't make sense - either you have a nice or
all releases driver, but not one that doesn't work everywhere _and_ looks
horrible.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:33    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site