Messages in this thread | | | Date | Sun, 23 Feb 2003 21:24:32 +0000 | From | Russell King <> | Subject | Re: [PATCH] Make hot unplugging of PCI buses work |
| |
On Sun, Feb 23, 2003 at 04:01:10PM -0500, Scott Murray wrote: > Having beaten out something roughly similiar for the cPCI hotplug code, > I have a couple of comments: > 1) The description of pci_remove_bus_device says "informing the drivers > that the device has been removed", yet unless I'm missing some sysfs > wrinkle, no call will be made to an attached driver's remove callback.
pci_remove_all_bus_devices => pci_remove_bus_device => pci_remove_device => device_unregister => device_del => bus_remove_device => device_release_driver => driver->remove
> 2) The recursive bus handling in pci_remove_bus_device should probably > call pci_proc_detach_bus
Good catch - I'll create a new patch for Monday.
> and potentially should also update the parent bridge's subordinate > field.
Yes - I think this is something we may consider when sorting out the insertion.
However, whether x86 PCs will survive bus renumbering or not remains to be seen. We currently try to leave as much of the configuration intact from the BIOS.
-- Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux http://www.arm.linux.org.uk/personal/aboutme.html
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |