Messages in this thread | | | Subject | Re: [PATCH][2.5] convert atm_dev_lock from spinlock to semaphore | Date | Tue, 18 Feb 2003 23:52:50 -0500 | From | chas williams <> |
| |
In message <20030219025347.D22992@parcelfarce.linux.theplanet.co.uk>,Matthew Wilcox writes: >you seem to be under the impression that <linux/sem.h> has something >to do with linux semaphores. this is not the case; they're sysv semaphores.
sorry about that. i just picked what seemed like likely culprits for header files.
>apart from this, i think it's a pretty bad idea to just replace the >spinlocks with semaphores. atm really needs fixing properly.
yes, atm_dev_lock is wrapped around large chunks of the code. however, it should probably never have been a spinlock--it certainly doesnt need to be one. as a mutex its far less offensive. i am willing to take suggestions as to what would need to be done to fix atm properly? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |