lkml.org 
[lkml]   [2003]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] EISA/sysfs update
    From
    Date
    >>>>> "Ivan" == Ivan Kokshaysky <ink@jurassic.park.msu.ru> writes:

    Ivan> On Fri, Feb 14, 2003 at 11:16:24AM +0100, Marc Zyngier wrote:
    >> # - Add driver for i82375 PCI/EISA bridge.

    Ivan> I believe this driver will work for any PCI/EISA bridge without
    Ivan> any changes, not only for i82375. Probably we need to look for a
    Ivan> class code rather than a device id.

    Unfortunately, the i82375 appears to be unclassified :

    00:07.0 Non-VGA unclassified device: Intel Corp. 82375EB (rev 03)

    I'll had PCI_CLASS_BRIDGE_EISA anyway, just in case.

    Ivan> Also, to get rid of that x86-ism I'd suggest something like

    Ivan> - i82375_root.bus_base_addr = 0; /* Warning, this is a x86-ism */
    Ivan> - i82375_root.res = &ioport_resource;
    Ivan> + i82375_root.res = pdev->bus->resource[0];
    Ivan> + i82375_root.bus_base_addr = pdev->bus->resource[0]->start;
    Ivan> i82375_root.slots = EISA_MAX_SLOTS;

    Ivan> Without that you'll have resource conflicts on multi-hose alphas.

    Applied, thanks.

    M.
    --
    Places change, faces change. Life is so very strange.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:33    [W:0.025 / U:120.976 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site