lkml.org 
[lkml]   [2003]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Fix random memory corruption during suspend-to-RAM resume
Hi!

> > > Hmm.. The stack grows downwards, are you sure you don't really mean
> > >
> > > mov $(wakeup_end-wakeup_code),%sp
> > >
> > > (because wakeup_end is the end of the wakeup_stack area..)
> >
> > Yes, I'm sure:
>
> No. The code is crap. Please send a _fixed_ patch that clearly puts the
> stack pointer at the _end_ of the stack.
>
> What you are sure of is that is _happens_ to work by pure luck.
>
> I'd rather have known-broken code in the kernel than code that works by
> mistake. The former at least gets fixed.

It should be already in the queue (waiting on my home machine sorry),
along with fix to make it all fit in one page.

Pavel
--
Casualities in World Trade Center: ~3k dead inside the building,
cryptography in U.S.A. and free speech in Czech Republic.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:33    [from the cache]
©2003-2011 Jasper Spaans