Messages in this thread | | | Subject | Re: [PATCH] 2.5.59 : drivers/net/fc/iph5526.c | Date | Mon, 10 Feb 2003 14:01:13 +0100 | From | Horst von Brand <> |
| |
Rusty Russell <rusty@rustcorp.com.au> said:
[...]
> > - for (i = 0; i < clone_list[i].vendor_id != 0; i++)
i < clone_list[i].vendor_id != 0 is (i < clone_list[i].vendor_id) != 0 is just i < clone_list[i].vendor_id, so the for is done for i = 0 and possibly for 1. Getting this effect (if desired) with an if is a load clearer.
Having i twice in the condition is also highly suspicious... is this code ever executed? It looks like a bad screwup in the condition that went unnoticed because it was never hit. -- Dr. Horst H. von Brand User #22616 counter.li.org Departamento de Informatica Fono: +56 32 654431 Universidad Tecnica Federico Santa Maria +56 32 654239 Casilla 110-V, Valparaiso, Chile Fax: +56 32 797513 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |