Messages in this thread | | | Date | Wed, 31 Dec 2003 02:53:09 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH linux-2.6.0-test10-mm1] filemap_fdatawait.patch |
| |
Suparna Bhattacharya <suparna@in.ibm.com> wrote: > > If PG_writeback is not set, it moves on to process the next page -- without > falling through to wait_on_page_writeback, isn't that so ? > Another thread could have pulled the page off io_pages, put it on locked > pages, and not set PG_writeback as yet.
OK, so a (well commented!) lock_page() in filemap_fdatawait() would seem to plug that. I recall being worried that this might be livelockable against ongoing read activity, but that doesn't sound right - such pages won't be on locked_pages().
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |