lkml.org 
[lkml]   [2003]   [Dec]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Subject[TRIVIAL PATCH] superfluous assignement in ide_diag_taskfile()
From
Date
Hi,
>From ide_diag_taskfile()

ide_init_drive_taskfile(&rq);
rq.flags = REQ_DRIVE_TASKFILE;
rq.buffer = buf;

but in ide_init_drive_taskfile() we've got:

void ide_init_drive_taskfile (struct request *rq)
{
memset(rq, 0, sizeof(*rq));
rq->flags = REQ_DRIVE_TASKFILE;
}
The REQ_DRIVE_TASKFILE assignement in ide_diag_taskfile() looks
superfluous.
Patch attached.

--
Frederik DEWEERDT
--- /usr/src/linux-2.6.0/drivers/ide/ide-taskfile.c 2003-12-18 15:41:19.000000000 +0100
+++ linux/drivers/ide/ide-taskfile.c 2003-12-22 11:12:06.000000000 +0100
@@ -1372,7 +1372,6 @@
struct request rq;

ide_init_drive_taskfile(&rq);
- rq.flags = REQ_DRIVE_TASKFILE;
rq.buffer = buf;

/*
\
 
 \ /
  Last update: 2005-03-22 13:59    [W:0.245 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site