Messages in this thread | | | Subject | Re: [PATCH] CONFIG_PCMCIA_PROBE fix | From | Andres Salomon <> | Date | Mon, 22 Dec 2003 12:18:42 -0500 |
| |
On Mon, 2003-12-22 at 04:48, Russell King wrote: > On Mon, Dec 22, 2003 at 12:48:44AM -0500, Andres Salomon wrote: > > Some time ago, Russell King submitted a patch to use CONFIG_PCMCIA_PROBE > > instead of CONFIG_ISA in pcmcia probing code. Unfortunately, > > CONFIG_PCMCIA_PROBE still is only set if CONFIG_ISA is set. This means > > that if ISA isn't enabled, certain things break in 2.6; for example, my > > pcmcia nic/modem (using pcnet_cs/serial_cs). These worked fine in 2.4; > > I tracked the behavior to the fact that if irq_mask is set on a pcmcia > > socket (instead of pci_irq), and PCMCIA_PROBE isn't set, > > pcmcia_request_irq refuses to assign an irq. Most of the pcmcia bridges > > appear to set an irq_mask, so the attached patch changes Kconfig to set > > CONFIG_PCMCIA_PROBE if any of those bridges are selected. > > > > Please apply this (or an alternative fix), as it fixes a 2.6 regression > > in pcmcia functionality. > > Please don't. David Hinds has a better fix for this, which changes > the way we handle the allocation of IRQs. David's change is all > round a far better way to handle the problem - if all ISA interrupts > are used or unavailable, we fall back to using the PCI interrupt > instead. > > Please also note that there /is/ a PCMCIA list which patches should > be forwarded to - linux-pcmcia which is at lists.infradead.org
Please put the list in the MAINTAINERS file; right now, linux-kernel@vger.kernel.org is listed as the relevant list.
[unhandled content-type:application/pgp-signature] | |