Messages in this thread Patch in this message | | | Subject | Re: atomic copy_from_user? | From | Rob Love <> | Date | Mon, 22 Dec 2003 15:55:06 -0500 |
| |
On Mon, 2003-12-22 at 13:26, Joe Korty wrote:
> Shouldn't the dec_prempt_count() in kunmap_atomic() be followed > by a preempt_check_resched()???
Probably.
Actually, dec_preempt_count() ought to call preempt_check_resched() itself. In the case of !CONFIG_PREEMPT, that call would simply optimize away.
Attached patch is against 2.6.0.
Rob Love
linux/preempt.h | 1 + 1 files changed, 1 insertion(+)
diff -urN include/linux/preempt.h.orig include/linux/preempt.h --- include/linux/preempt.h.orig 2003-12-22 15:53:11.329113296 -0500 +++ include/linux/preempt.h 2003-12-22 15:53:51.314034664 -0500 @@ -18,6 +18,7 @@ #define dec_preempt_count() \ do { \ preempt_count()--; \ + preempt_check_resched(); \ } while (0) #ifdef CONFIG_PREEMPT
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |