Messages in this thread Patch in this message | | | Date | Sat, 20 Dec 2003 15:41:25 +0100 (CET) | From | Guennadi Liakhovetski <> | Subject | Re: SCSI AM53C974 driver missing in 2.6.0? |
| |
On Fri, 19 Dec 2003, Gene Heskett wrote:
> Hey, how about us advansis users? There is at least one, me... And > thats the only driver in the whole compile that spits out visible > warnings about check_region() being deprecated. But its still > working, so far. I presume it will until such time as check_region() > is actually removed from wherever it lives.
Well, wouldn't it suffice just to remove the deprecated checks? The only (for recent kernels) request_region() does check the return code. So, this should do:
--- drivers/scsi/advansys.c~ Mon Nov 24 20:43:42 2003 +++ drivers/scsi/advansys.c Sat Dec 20 15:34:00 2003 @@ -4619,13 +4619,7 @@ ASC_DBG1(1, "advansys_detect: probing I/O port 0x%x...\n", iop); - if (check_region(iop, ASC_IOADR_GAP) != 0) { - printk( -"AdvanSys SCSI: specified I/O Port 0x%X is busy\n", iop); - /* Don't try this I/O port twice. */ - asc_ioport[ioport] = 0; - goto ioport_try_again; - } else if (AscFindSignature(iop) == ASC_FALSE) { + if (AscFindSignature(iop) == ASC_FALSE) { printk( "AdvanSys SCSI: specified I/O Port 0x%X has no adapter\n", iop); /* Don't try this I/O port twice. */ @@ -10003,12 +9997,6 @@ } for (; i < ASC_IOADR_TABLE_MAX_IX; i++) { iop_base = _asc_def_iop_base[i]; - if (check_region(iop_base, ASC_IOADR_GAP) != 0) { - ASC_DBG1(1, - "AscSearchIOPortAddr11: check_region() failed I/O port 0x%x\n", - iop_base); - continue; - } ASC_DBG1(1, "AscSearchIOPortAddr11: probing I/O port 0x%x\n", iop_base); if (AscFindSignature(iop_base)) { return (iop_base); Guennadi --- Guennadi Liakhovetski
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |