Messages in this thread | | | Date | Mon, 01 Dec 2003 16:02:01 +0900 | From | IWAMOTO Toshihiro <> | Subject | Re: [PATCH] 2.6.0-test10 O_DIRECT memory leak fix |
| |
At Tue, 25 Nov 2003 14:49:50 -0800, Badari Pulavarty wrote: > > [1 <text/plain; us-ascii (quoted-printable)>] > Hi Andrew, > > I found the problem with O_DIRECT memory leak. > > The problem is, when we are doing DIO read and crossed the end of file - > we don't release referencess on all the pages we got from get_user_pages(). > (since it is a sucess case). > > The fix is to call dio_cleanup() even for sucess cases. Can you please > review this ? I tested the patch with fsstress and there are no memory leak > problems now. > > Thanks, > Badari > [2 dioleak.patch <text/x-diff; us-ascii (7bit)>]
I've tested this patch with linux-2.6.0-test11 (plus my memory hotplug patch) on the machine I observed the memory leak. The leak seems to be fixed. Thanks.
-- IWAMOTO Toshihiro - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |