Messages in this thread | | | Date | Fri, 7 Nov 2003 22:22:51 +0100 | From | Jens Axboe <> | Subject | Re: [Bug 1412] Copy from USB1 CF/SM reader stalls, no actual content is read (only directory structure) |
| |
On Fri, Nov 07 2003, Nicolas Mailhot wrote: > Le ven 07/11/2003 à 10:25, Nicolas Mailhot a écrit : > > Le ven 07/11/2003 à 10:09, Jens Axboe a écrit : > > > > Try with this debug patch then, does it work now? > > > > > > ===== drivers/scsi/scsi_lib.c 1.77 vs edited ===== > > > --- 1.77/drivers/scsi/scsi_lib.c Tue Oct 14 09:28:06 2003 > > > +++ edited/drivers/scsi/scsi_lib.c Fri Nov 7 10:08:52 2003 > > > @@ -1215,6 +1215,7 @@ > > > > > > u64 scsi_calculate_bounce_limit(struct Scsi_Host *shost) > > > { > > > +#if 0 > > > struct device *host_dev; > > > > > > if (shost->unchecked_isa_dma) > > > @@ -1229,6 +1230,9 @@ > > > * hardware have no practical limit. > > > */ > > > return BLK_BOUNCE_ANY; > > > +#else > > > + return BLK_BOUNCE_HIGH; > > > +#endif > > > } > > > > > > struct request_queue *scsi_alloc_queue(struct scsi_device *sdev) > > > > Will try this evening when I have physical access to the system. (It's > > difficult to plug a USB device via ssh;) > > Well, it does work now (couldn't believe my eyes, tried three times in a > row just to be sure). Is this supposed to be a definitive fix that will > be in the next bk snapshots or should I wait for something else ?
No it's not a definitive fix. It was just a test - if it works with the patch applied, it confirms the theory that usb storage is broken wrt highmem.
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |