Messages in this thread Patch in this message | | | Date | Tue, 18 Nov 2003 20:07:05 +0100 | From | Adrian Bunk <> | Subject | [2.4 patch] fixup after synclink update |
| |
2.4.23-rc contains a synclink update that contains the following change:
<-- snip -->
static struct pci_driver synclink_pci_driver = { name: "synclink", id_table: synclink_pci_tbl, probe: synclink_init_one, - remove: __devexit_p(synclink_remove_one), + remove: synclink_remove_one, };
<-- snip -->
This change causes the following compile error when compiling the driver statically into a kernel without hotplug support:
<-- snip -->
... --end-group \ -o vmlinux local symbol 0: discarded in section `.text.exit' from drivers/char/char.o make: *** [vmlinux] Error 1
<-- snip -->
The following patch reverts this bogus change:
--- linux-2.4.23-rc1-full-nohotplug/drivers/char/synclink.c.old 2003-11-18 18:30:06.000000000 +0100 +++ linux-2.4.23-rc1-full-nohotplug/drivers/char/synclink.c 2003-11-18 18:31:14.000000000 +0100 @@ -945,7 +945,7 @@ name: "synclink", id_table: synclink_pci_tbl, probe: synclink_init_one, - remove: synclink_remove_one, + remove: __devexit_p(synclink_remove_one), }; static struct tty_driver serial_driver, callout_driver;
Please apply for 2.4.23-rc2.
TIA Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |