lkml.org 
[lkml]   [2003]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: BUG: Kernel Panic: kernel-2.6.0-test9-bk21 for alpha in scsi context ll_rw_blk.c
    On Mon, Nov 17, 2003 at 10:48:49PM +0100, Falk Hueffner wrote:
    > Well, the architecture manual requires these instructions have no
    > visible effect whatsoever, i. e. they never trap.

    No. Unaligned != invalid.

    We shouldn't prefetch the spinlocks on UP.

    Ivan.

    --- 2.6/include/asm-alpha/processor.h Sat Oct 25 22:44:54 2003
    +++ linux/include/asm-alpha/processor.h Tue Nov 18 01:48:39 2003
    @@ -78,6 +78,11 @@ unsigned long get_wchan(struct task_stru
    #define ARCH_HAS_PREFETCHW
    #define ARCH_HAS_SPINLOCK_PREFETCH

    +#ifndef CONFIG_SMP
    +/* Nothing to prefetch. */
    +#define spin_lock_prefetch(lock) do { } while (0)
    +#endif
    +
    #if __GNUC__ > 3 || (__GNUC__ == 3 && __GNUC_MINOR__ >= 1)
    extern inline void prefetch(const void *ptr)
    {
    @@ -89,10 +94,13 @@ extern inline void prefetchw(const void
    __builtin_prefetch(ptr, 1, 3);
    }

    +#ifdef CONFIG_SMP
    extern inline void spin_lock_prefetch(const void *ptr)
    {
    __builtin_prefetch(ptr, 1, 3);
    }
    +#endif
    +
    #else
    extern inline void prefetch(const void *ptr)
    {
    @@ -104,10 +112,13 @@ extern inline void prefetchw(const void
    __asm__ ("ldq $31,%0" : : "m"(*(char *)ptr));
    }

    +#ifdef CONFIG_SMP
    extern inline void spin_lock_prefetch(const void *ptr)
    {
    __asm__ ("ldq $31,%0" : : "m"(*(char *)ptr));
    }
    +#endif
    +
    #endif /* GCC 3.1 */

    #endif /* __ASM_ALPHA_PROCESSOR_H */
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2005-03-22 13:58    [W:0.025 / U:0.404 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site