lkml.org 
[lkml]   [2003]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: AS spin lock bugs
On Thu, Nov 13 2003, Jens Axboe wrote:
> @@ -959,12 +960,12 @@
> if (!aic)
> return;
>
> - spin_lock(&aic->lock);
> + spin_lock_irqsave(&aic->lock, flags);
> if (arq->is_sync == REQ_SYNC) {
> set_bit(AS_TASK_IORUNNING, &aic->state);
> aic->last_end_request = jiffies;
> }
> - spin_unlock(&aic->lock);
> + spin_unlock_irqrestore(&aic->lock, flags);
>
> put_io_context(arq->io_context);
> }

BTW, this looks bogus. Why do you need any locking there?

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:58    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site