lkml.org 
[lkml]   [2003]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: 2.6.0-test9-bk16 ALi M5229 kernel boot error

On Wed, 12 Nov 2003, Daniel Craig wrote:
>
> Does anyone have any idea what might be going wrong...?

Yes. The ALI driver has some really strange code to avoid tweaking non-ALI
southbridges.

But the thing is, it breaks even _with_ ALI southbridges, if we just don't
find the ALI bridge we expect.

Does this patch fix it?

Linus

---
--- 1.15/drivers/ide/pci/alim15x3.c Sun Aug 24 15:33:30 2003
+++ edited/drivers/ide/pci/alim15x3.c Tue Nov 11 19:03:21 2003
@@ -578,7 +578,6 @@
{
unsigned long flags;
u8 tmpbyte;
- struct pci_dev *north = pci_find_slot(0, PCI_DEVFN(0,0));

pci_read_config_byte(dev, PCI_REVISION_ID, &m5229_revision);

@@ -625,11 +624,9 @@

/*
* We should only tune the 1533 enable if we are using an ALi
- * North bridge. We might have no north found on some zany
- * box without a device at 0:0.0. The ALi bridge will be at
- * 0:0.0 so if we didn't find one we know what is cooking.
+ * south bridge.
*/
- if (north && north->vendor != PCI_VENDOR_ID_AL) {
+ if (!isa_dev) {
local_irq_restore(flags);
return 0;
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-11-18 23:46    [W:0.085 / U:0.500 seconds]
©2003-2014 Jasper Spaans. Advertise on this site