lkml.org 
[lkml]   [2003]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: LKCD Network dump over netpoll patch (2.6.0-test9)
On Mon, Nov 10, 2003 at 07:37:42PM +0530, Prasanna S Panchamukhi wrote:
> Hi,
>

Hi.

> + put_unaligned(htonl(reply.nr), (u32 *) (tmp_membuf + 1));
> + put_unaligned(htonl(reply.code), (u32 *) (tmp_membuf + 5));
> + put_unaligned(htonl(reply.info), (u32 *) (tmp_membuf + 9));
> +
> + memcpy((tmp_membuf + HEADER_LEN), buff + offset, 1024);
> + netpoll_send_udp(np, tmp_membuf, (1024 + HEADER_LEN));

There's quite a few instances of this header business, it could really
stand to be in its own netdump_send(nr, code, info, data) function.

> - dump_ndev->poll_controller(dump_ndev);
> + netpoll_poll(&net_dev->np);
> zap_completion_queue();
...
> +void zap_completion_queue(void);

Instead of this (missing netpoll_, btw), how about we call
zap_completion_queue inside of netpoll_poll?

--
Matt Mackall : http://www.selenic.com : Linux development and consulting
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:58    [W:0.084 / U:0.092 seconds]
©2003-2011 Jasper Spaans. Advertise on this site