Messages in this thread | | | Date | Wed, 8 Oct 2003 17:48:51 +0100 | From | Dave Jones <> | Subject | Re: [PATCH] Poll-based IDE driver |
| |
On Wed, Oct 08, 2003 at 09:36:36AM -0700, Andre Hedrick wrote: > > Does not matter, priority is to get content to platter and the hell with > everything else.
I don't buy this. Without correct udelay()'s, how is code like this..
for (i = 0; i < 10; i++) { dump_udelay(1); if (OK_STAT((stat = hwif->INB(IDE_STATUS_REG)), good, bad)) return 0; }
expected to work ? It won't wait for 10usec at all, but be over almost instantly. Ramming commands at the drive before its status has settled doesn't strike me as a particularly safe thing to do.
Dave
-- Dave Jones http://www.codemonkey.org.uk - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |