Messages in this thread | | | Date | Mon, 6 Oct 2003 15:42:25 +0200 | From | Jens Axboe <> | Subject | Re: [PATCH] release_region in cciss block driver |
| |
On Mon, Oct 06 2003, Felipe W Damasio wrote: > Hi Andrew, > > Patch against 2.6.0-test6. > > Release a previous requested region if we're about the fail the > board initialization. Found by smatch. > > Please review and consider applying, > > Thanks. > > Felipe
> --- linux-2.6.0-test6/drivers/block/cciss.c.orig 2003-10-06 10:18:01.000000000 -0300 > +++ linux-2.6.0-test6/drivers/block/cciss.c 2003-10-06 10:25:04.000000000 -0300 > @@ -2185,6 +2185,7 @@ > schedule_timeout(HZ / 10); /* wait 100ms */ > } > if (scratchpad != CCISS_FIRMWARE_READY) { > + release_io_mem (c); > printk(KERN_WARNING "cciss: Board not ready. Timed out.\n"); > return -1; > }
Please at least try and follow the local style when you make changes.
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |