Messages in this thread |  | | | Date | Mon, 6 Oct 2003 21:04:30 +0200 (CEST) | | From | Krzysztof Benedyczak <> | | Subject | Re: POSIX message queues |
| |
On Sun, 5 Oct 2003, Manfred Spraul wrote:
> Krzysiek: What is MQ_IOC_CLOSE? It looks like a stale ioctl. Please > remove such code from the patch. It is used. If this ioctl will succeed we know that it was done on mqueue fs file. And thanks to it we get rid of the possibility of closing ordinary file descriptor with mq_close().
> > The last time I looked at your patch I noticed a race between creation > and setting queue attributes. Did you fix that? Yes - as Alan Cox suggested. But see below.
> I personally prefer syscalls, but that's just my personal preference. In our opinion also - and that was the reason why we initially had done this with syscall. But this was criticized. Mostly but Christopher Hellwig AFAIR. So we changed it ;-) ... Anyway:
Removing ioctls has mostly advantages (maybe except checking for permissions) and it's simply. Reusing code of msg_load/free/store - also no problem. Third issue is filesystem. IMHO removing it from userspace is unnecessary. It gives a lot of valuable informations (about notifications which can't be gather with POSIX calls). It is also convenient to rm queue to poll it. The things I think should be changed: mqueues should be be accessible from the module init time touch can create queue with system limits (?) multiple mounts of mqueue fs should show the same content.
With this functionality we will have some more convenient queues. Is it sensible?
( Implementing with syscalls will also solve proc/mounts dependency (which BTW can be turned of in library configure). )
Regards Krzysiek - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |