Messages in this thread Patch in this message | | | From | Bjorn Helgaas <> | Subject | Re: [PATCH 2.6] Warnings in 8250_acpi | Date | Mon, 6 Oct 2003 10:07:36 -0600 |
| |
On Monday 06 October 2003 2:38 am, Russell King wrote: > On Mon, Oct 06, 2003 at 01:31:55AM -0500, Dmitry Torokhov wrote: > > Lastest changes in 8250_acpi.c produce warnings about type mismatch > > in printk. We could either change format to print long long arguments > > or, until most of us are on 64 bits, just trim values to 32. > > I'd like Bjorn to comment before I apply this.
Oops, sorry about that. Here's my preference for fixing it:
===== drivers/serial/8250_acpi.c 1.3 vs edited ===== --- 1.3/drivers/serial/8250_acpi.c Wed Oct 1 03:11:17 2003 +++ edited/drivers/serial/8250_acpi.c Mon Oct 6 12:33:54 2003 @@ -28,8 +28,7 @@ req->iomem_base = ioremap(req->iomap_base, size); if (!req->iomem_base) { printk(KERN_ERR "%s: couldn't ioremap 0x%lx-0x%lx\n", - __FUNCTION__, addr->min_address_range, - addr->max_address_range); + __FUNCTION__, req->iomap_base, req->iomap_base + size); return AE_ERROR; } req->io_type = SERIAL_IO_MEM;
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |