Messages in this thread | | | From | Matthias Urlichs <> | Subject | Re: [PATCH] expand_resource | Date | Wed, 01 Oct 2003 19:50:10 +0200 |
| |
Hi, Matthew Wilcox wrote: > int new = expand_resource(res, size, align); > > if (new < 0) { > return new; > } else if (new == res->start) { > /* program start */ > } else { > /* program end */ > }
Umm, these /*program*/ starts/ends look backwards.
Personally, I'd check both independently. What stops expand_resource from doing both if there's no increase possible in only one direction to make room for <size>?
-- Matthias Urlichs | {M:U} IT Design @ m-u-it.de | smurf@smurf.noris.de Disclaimer: The quote was selected randomly. Really. | http://smurf.noris.de - - Battle, n.: A method of untying with the teeth a political knot that will not yield to the tongue. -- Ambrose Bierce - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |