Messages in this thread | | | Subject | Re: Ref-count problem in kset_find_obj? | From | "Martin Schwidefsky" <> | Date | Thu, 30 Oct 2003 09:46:43 +0100 |
| |
> > Yes, you're right. The function is pretty much unused, and I don't have a > > problem removing it, provided we can fix up the one user > > (arch/i386/kernel/edd.c). Unless of course, you're planning on using it.. > > At the moment, edd.c doesn't actually use it. It wants to - > find_bus() is a useful concept, but I haven't proven that the scsi_bus > list only has scsi_devices on it, so that code isn't compiled in at > present. If the scsi_bus list is clean now, then yes, I'll want to > turn it back on (after 2.6.0 is out) and will need find_bus() to be > possible.
We don't plan to use kset_find_obj in the near future but since Matt wants to use it, better fix it. The fix should be easy just add a kobject_get and make the caller of kset_find_obj return the reference again.
blue skies, Martin
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |