Messages in this thread | | | From | Bjorn Helgaas <> | Subject | Re: [PATCH 2.4.23-pre8] Remove broken prefetching in free_one_pgd() | Date | Thu, 30 Oct 2003 13:57:17 -0700 |
| |
On Friday 24 October 2003 4:21 pm, David Mosberger wrote: > >>>>> On Fri, 24 Oct 2003 15:16:59 -0700, "Luck, Tony" <tony.luck@intel.com> said: > >> Different arches behave differently, though. In the case of ia64, > >> it'a always safe to prefetch (even with lfetch.fault). > > Tony> Not quite always ... this was how I found the efi trim.bottom > Tony> bug, since Linux had allocated a pgd at 0xa00000-16k, and the > Tony> lfetch that reached out beyond the end of the page to the > Tony> uncacheable address 0xa00000 took an MCA. > > But don't confuse cause and effect! The MCA was caused by a bad TLB > entry. The lfetch only triggered the latent bug (as might have a > instruction-prefetch).
I'm assuming that the EFI memory map trim fixes prevent the bad TLB entry, and hence, the prefetching patch is not required by ia64 in 2.4. Tony, let me know if otherwise.
Bjorn
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |