Messages in this thread Patch in this message | | | From | David Mosberger <> | Date | Tue, 28 Oct 2003 16:16:04 -0800 | Subject | Re: status of ipchains in 2.6? |
| |
Yes, Rusty mentioned the same patch yesterday. I tried it now and ipchain masquerading seems to be working fine again.
--david
>>>>> On Tue, 28 Oct 2003 19:23:37 +0100, Martin Josefsson <gandalf@wlug.westbo.se> said:
Martin> Please try this patch that just got included in linus tree.
Martin> ChangeSet 1.1360, 2003/10/27 00:01:25-08:00, rusty@rustcorp.com.au
Martin> [NETFILTER]: Fix ipchains oops in NAT
Martin> We updated ip_nat_setup_info to set the initialized flag and call Martin> place_in_hashes, but *didn't* change the call in ip_fw_compat_masq.c Martin> which also calls place_in_hashes() itself (again!). Result: corrupt Martin> list, and next thing which lands in the same hash bucket goes boom.
Martin> Thanks to Andy Polyakov for chasing this down.
Martin> # This patch includes the following deltas: Martin> # ChangeSet 1.1359 -> 1.1360 Martin> # net/ipv4/netfilter/ip_fw_compat_masq.c 1.11 -> 1.12 Martin> #
Martin> ip_fw_compat_masq.c | 3 --- Martin> 1 files changed, 3 deletions(-)
Martin> diff -Nru a/net/ipv4/netfilter/ip_fw_compat_masq.c b/net/ipv4/netfilter/ip_fw_compat_masq.c Martin> --- a/net/ipv4/netfilter/ip_fw_compat_masq.c Mon Oct 27 12:07:33 2003 Martin> +++ b/net/ipv4/netfilter/ip_fw_compat_masq.c Mon Oct 27 12:07:33 2003 Martin> @@ -91,9 +91,6 @@ Martin> WRITE_UNLOCK(&ip_nat_lock); Martin> return ret; Martin> } Martin> - Martin> - place_in_hashes(ct, info); Martin> - info->initialized = 1; Martin> } else Martin> DEBUGP("Masquerading already done on this conn.\n"); Martin> WRITE_UNLOCK(&ip_nat_lock); Martin> -- Martin> /Martin - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |