Messages in this thread Patch in this message | | | From | Rob Landley <> | Subject | [patch] make Kconfig choice menu help text work in -test8 | Date | Sat, 25 Oct 2003 22:16:02 -0500 |
| |
> > (Looking at the patch, it prints stuff to stderr, adds adds a "selected" > > case to something that was previously on/off... I don't think it's > > really addressing this issue...) > > That explains why Roman Zippel did not apply it - thanks for the testing. > > Sam
I had a spare couple of hours this evening, so I whipped up a patch of my own to actually fix the thing, working from first principles and tracing through yacc and lexx code at one point.
With the benefit of hindsight, it turns out the other patch wasn't actually that far off. I only noticed that just now, I had to figure out how mconf.c was shelling out to lxdialog and getting data back on stderr first to realize that yes, printing stuff to stderr is in fact an important part of getting this to work. :)
Here's the fix. Go to into "processor type and features" from the main menu, then the "subarchitecture" menu at the top of that, and notice the entries in it now have help options.
Rob
diff -ru linux-2.6.0-test8/scripts/kconfig/mconf.c linux-test8-new/scripts/kconfig/mconf.c --- linux-2.6.0-test8/scripts/kconfig/mconf.c 2003-10-17 16:42:56.000000000 -0500 +++ linux-test8-new/scripts/kconfig/mconf.c 2003-10-25 21:59:31.000000000 -0500 @@ -635,7 +635,9 @@ sym_set_tristate_value(menu->sym, yes); return; case 1: - show_help(menu); + if(sscanf(input_buf, "%p", &child) != 1) + break; + show_help(child); break; case 255: return; diff -ru linux-2.6.0-test8/scripts/lxdialog/checklist.c linux-test8-new/scripts/lxdialog/checklist.c --- linux-2.6.0-test8/scripts/lxdialog/checklist.c 2003-10-17 16:43:10.000000000 -0500 +++ linux-test8-new/scripts/lxdialog/checklist.c 2003-10-25 21:56:04.000000000 -0500 @@ -299,12 +299,6 @@ continue; /* wait for another key press */ } switch (key) { - case 'H': - case 'h': - case '?': - delwin (dialog); - free (status); - return 1; case TAB: case KEY_LEFT: case KEY_RIGHT: @@ -314,6 +308,11 @@ print_buttons(dialog, height, width, button); wrefresh (dialog); break; + case 'H': + case 'h': + case '?': + button=1; + /* Fall through */ case 'S': case 's': case ' ': @@ -347,7 +346,9 @@ } } - } + } else { + fprintf(stderr,"%s",items[choice * 3]); + } delwin (dialog); free (status); return button; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |